linux-kernel - Re: [PATCH] x86: trim ACPI sleep stack buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081009180747.GC12507@elf.ucw.cz>
Date:	Thu, 9 Oct 2008 20:07:47 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Matt Mackall <mpm@...enic.com>
Cc:	"Moore, Robert" <robert.moore@...el.com>,
	Len Brown <lenb@...nel.org>, Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH] x86: trim ACPI sleep stack buffer

On Thu 2008-10-09 12:41:50, Matt Mackall wrote:
> On Thu, 2008-10-09 at 10:23 -0700, Moore, Robert wrote:
> > Sounds like you need a
> > 
> > #define DEFAULT_STACK_SIZE 4096
> > 
> > Somewhere.
> 
> Or maybe something like this:
> 
> 
> x86: remove magic number from ACPI sleep stack buffer
> 
> Signed-off-by: Matt Mackall <mpm@...enic.com>

Acked-by: Pavel Machek <pavel@...e.cz>

> diff -r 375a00b8bf10 arch/x86/kernel/acpi/sleep.c
> --- a/arch/x86/kernel/acpi/sleep.c	Thu Oct 09 12:38:55 2008 -0500
> +++ b/arch/x86/kernel/acpi/sleep.c	Thu Oct 09 12:40:10 2008 -0500
> @@ -97,7 +97,7 @@
>  #else /* CONFIG_64BIT */
>  	header->trampoline_segment = setup_trampoline() >> 4;
>  #ifdef CONFIG_SMP
> -	stack_start.sp = temp_stack + 4096;
> +	stack_start.sp = temp_stack + sizeof(temp_stack);
>  #endif
>  	initial_code = (unsigned long)wakeup_long64;
>  	saved_magic = 0x123456789abcdef0;
> 
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/