linux-kernel - Re: rc9 + orinoco WPA patchset: BUG: scheduling while atomic loading firmware with PCMCIA adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1223581233.14959.16.camel@dhcp-100-3-195.bos.redhat.com>
Date:	Thu, 09 Oct 2008 15:40:33 -0400
From:	Dan Williams <dcbw@...hat.com>
To:	Andrey Borzenkov <arvidjaar@...mail.ru>
Cc:	orinoco-devel@...ts.sourceforge.net,
	linux-wireless@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: rc9 + orinoco WPA patchset: BUG: scheduling while atomic
	loading firmware with PCMCIA adapter

On Thu, 2008-10-09 at 23:21 +0400, Andrey Borzenkov wrote:
> On Thursday 09 October 2008, Dan Williams wrote:
> > 
> > On Thu, 2008-10-09 at 19:59 +0400, Andrey Borzenkov wrote:
> > > On Thursday 09 October 2008, Matthew Wilcox wrote:
> > > > 
> > > > On Thu, Oct 09, 2008 at 05:22:55PM +0400, Andrey Borzenkov wrote:
> > > > > After loading orinoco and "inserting" adapter I get either BUG with
> > > > > endless loop (attached) or kernel panic on NULL pointer dereference
> > > > > (was not able capture). Adapter works fine with wlags49 driver.
> > > > 
> > > > It looks like you've fallen off the bottom of the kernel stack.  Do you
> > > > have 4k stacks enabled in your config?
> > > > 
> > > 
> > > You are right. Using 8K stacks load and runs fine. Hmm ... not nice
> > > from it :p
> > 
> > == driver bug; the driver should not require large stacks and this
> > should get fixed.
> > 
> 
> The attached patch fixes 4K stack for me. I have not tested spectrum case.

Looks pretty good, although if nobody can test the Symbol case (all I
have is Intersil firmware) maybe you should not use priv->pda_size but
#define SYMBOL_PDA_SIZE 256 and use that for the hermes_read_pda()
length just to ensure the patched code is functionally the same as
before the patch.

Dan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/