linux-kernel - Re: [patch] clean hex output of ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1223596426.17735.0.camel@brick>
Date:	Thu, 09 Oct 2008 16:53:46 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Joe Perches <joe@...ches.com>
Subject: Re: [patch] clean hex output of ftrace

On Thu, 2008-10-09 at 14:31 +0200, Ingo Molnar wrote:
> * Harvey Harrison <harvey.harrison@...il.com> wrote:
> 
> > On Wed, 2008-10-08 at 17:16 -0700, Joe Perches wrote:
> > > On Wed, 8 Oct 2008, Harvey Harrison wrote:
> > > > From: Harvey Harrison <harvey.harrison@...il.com>
> > > > Subject: [PATCH] ftrace: Fix inversion of hex output and use common routines
> > > 
> > > You're quick...
> > > 
> > > >  	BUG_ON(len >= HEX_CHARS);
> > > 
> > > I think the BUG_ON is senseless.
> > > 
> > 
> > Agreed, it probably meant to say BUG_ON(len * 2 > HEX_CHARS -1)
> > 
> > But as this is only called from within a helper macro, it could be
> > changed to a build-time check instead of a runtime:
> > 
> > From: Harvey Harrison <harvey.harrison@...il.com>
> > Subject: [PATCH] trace: add build-time check to avoid overrunning hex buffer
> 
> applied to tip/tracing/core:
> 
>  bb86ba7: trace: add build-time check to avoid overrunning hex buffer
>  32ce86f: ftrace: fix hex output mode of ftrace
> 

Thinking about this, these should probably be forwarded to -stable once
they go into mainline.

Cheers,

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/