lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Oct 2008 09:01:32 -0700 From: "Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com> To: Cyrill Gorcunov <gorcunov@...il.com> CC: Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com>, linux-kernel <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] Typo in x86 apic.c with DIVISOR setup >-----Original Message----- >From: Cyrill Gorcunov [mailto:gorcunov@...il.com] >Sent: Thursday, October 09, 2008 10:39 PM >To: Pallipadi, Venkatesh >Cc: Ingo Molnar; Thomas Gleixner; H. Peter Anvin; linux-kernel >Subject: Re: [PATCH] Typo in x86 apic.c with DIVISOR setup > > >But here is not the same > > apic_write(APIC_TDCR, > (tmp_value & ~(APIC_TDR_DIV_1 | APIC_TDR_DIV_TMBASE)) | >- APIC_TDR_DIV_16); >+ APIC_TDR_DIV); > >On x86_64 it will be 1 now but we've used 16 for a long time in purpose >to slowdown processor's bus CLKs from APIC point of view. So I >don't think >it's good idea to change it now. If we start using divisor 1 >today -- it would >work for some time 'till processor bus raised to the some speed when >we'll get counter underflow before calibration finished. > I understand that using 1 instead of 16 makes APIC timer count 16 times faster. I did that change as I thought that was the intention of making APIC_DIVISOR as 1. Otherwise, there is no real impact of APIC_DIVISOR #define from being there. It Is just changing the value of calibration_result across 32 bit and 64 bit kernels. For example, "host bus clock speed" message will print different values across 32 bit and 64 bit kernels on the same system, if we just make APIC_DIVISOR 16 for 32 bit and 1 for 64 bit kernel. Thanks, Venki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists