linux-kernel - Re: [PATCH 22/27] serial: Make uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Oct 2008 09:19:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jwboyer@...il.com
Cc:	alan@...hat.com, torvalds@...l.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH 22/27] serial: Make uart_port's ioport "unsigned long".

From: Josh Boyer <jwboyer@...il.com>
Date: Fri, 10 Oct 2008 08:54:34 -0400

> On Fri, Oct 10, 2008 at 11:50:56AM +0100, Alan Cox wrote:
> >From: David Miller <davem@...emloft.net>
> >
> >Otherwise the top 32-bits of the resource value get chopped
> >off on 64-bit systems, and the resulting I/O accesses go to
> >random places.
> >
> >Thanks to testing and debugging by Josip Rodin, which helped
> >track this down.
> >
> >Signed-off-by: David S. Miller <davem@...emloft.net>
> >Signed-off-by: Alan Cox <alan@...hat.com>
> 
> I emailed on an earlier posting of this about using resource_size_t
> instead as we have 32-bit CPUs with 64-bit address spaces.  If I'm
> totally wrong, that's fine but I'm still wondering if that would be
> a better general solution.

That seems like a fine idea to me, please post a follow-on patch
if you like :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/