linux-kernel - Re: [git pull] x86 updates for v2.6.28, phase #1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Oct 2008 13:43:17 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Vegard Nossum <vegard.nossum@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [git pull] x86 updates for v2.6.28, phase #1

Vegard Nossum wrote:
> 
> Note: If you don't want the double underscores anywhere, this patch is
> not enough.
> 
> For example:
> 
>> -#endif /* ASM_X86__MACH_DEFAULT__MACH_TIMER_H */
>> +#endif /* _ASM_X86_MACH_DEFAULT__MACH_TIMER_H */
> 
> There are also a few non-trivial changes, which could break with a
> naïve sed script. So I suggest to simply revert it, it's a lot safer
> than trying to patch it up in the last minute.
> 
> I'm obviously also sorry for causing this problem in the first place... *blush*
> 

Double underscores aren't the problem per se, the problem is having 
changes _ASM_X86_ to ASM_X86__ and therefore violating the namespace.

That being said, I don't personally like the double underscores.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/