[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 10 Oct 2008 23:49:58 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Huang Ying <ying.huang@...el.com>, linux-kernel@...r.kernel.org,
hpa@...or.com, tglx@...utronix.de
Subject: Re: [PATCH -mm -v5] Separate atomic_t declaration from
asm/atomic.h into asm/atomic_def.h
* Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Wed, 08 Oct 2008 17:44:30 +0800
> Huang Ying <ying.huang@...el.com> wrote:
>
> > From: Huang Ying <ying.huang@...el.com>
> >
> > asm/atomic.h contains both declaration and implementation of atomic_t. So
> > there are some implementation related files included in asm/atomic.h. And
> > atomic_t is a typedef. Combination of above makes it impossible to use
> > atomic_t in files included by atomic.h. Such as atomic_t can not be used
> > in linux/kernel.h on i386, because it is included by asm/atomic.h.
> >
> > It is reasonable to separate declaration from implementation. So a new
> > file atomic_types.h is added for every architecture to accommodate the
> > declaration of atomic_t.
> >
> > Includes fixes from Andrew Moton.
> >
> > Signed-off-by: Huang Ying <ying.huang@...el.com>
> > Reviewed-by: Ingo Molnar <mingo@...e.hu>
>
> The difference between what-i-currently-have and what-you-just-sent is
> below. It's quite large.
>
> Can you explain this update please?
i've been giving review feedback to make it all fit into existing
namespace concepts better. Should have no change in functionality. (But
i have not tested it)
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists