linux-kernel - Re: [PATCH 4/6 v3] PCI: support SR-IOV capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Oct 2008 15:24:49 +0800
From:	"Zhao, Yu" <yu.zhao@...el.com>
To:	Alex Chiang <achiang@...com>, "Zhao, Yu" <yu.zhao@...el.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Grant Grundler <grundler@...isc-linux.org>,
	Matthew Wilcox <matthew@....cx>,
	Roland Dreier <rdreier@...co.com>, Greg KH <greg@...ah.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"virtualization@...ts.linux-foundation.org" 
	<virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH 4/6 v3] PCI: support SR-IOV capability

Alex Chiang wrote:
> Do you want to emit a kobject_uevent here after success?
> 
> Alternatively, have you investigated making these virtual
> functions into real struct device's? You get a lot of sysfs stuff
> for free if you do so, including correct place in sysfs hierarchy
> and uevents, etc.

The virtual functions are rpresented by 'struct pci_dev', so same as 
real device, the standard sysfs entries are created by pci_bus_add_device.

> 
> My major complaints from last round (more documentation,
> shouldn't be a PCI hotplug driver) have been addressed. I'll let
> others comment about the other parts of your patch series.

Thanks, Alex.

> 
> Thanks.
> 
> /ac
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/