linux-kernel - Re: rc9 + orinoco WPA patchset: BUG: scheduling while atomic loading firmware with PCMCIA adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200810101141.38929.arvidjaar@newmail.ru>
Date:	Fri, 10 Oct 2008 11:41:37 +0400
From:	Andrey Borzenkov <arvidjaar@...mail.ru>
To:	Dave <kilroyd@...glemail.com>
Cc:	orinoco-devel@...ts.sourceforge.net,
	linux-wireless@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: rc9 + orinoco WPA patchset: BUG: scheduling while atomic loading firmware with PCMCIA adapter

On Friday 10 October 2008, Dave wrote:
> Thanks for identifying the problem. The Agere case looks good - a few suggestions for the Symbol case though:

Updated patch attached

>  
> But you absolutely have to kfree(pda) here.

Yes, I forgot; sorry.

> Dan Williams wrote:
> > maybe you should not use priv->pda_size but
> > #define SYMBOL_PDA_SIZE 256 and use that for the hermes_read_pda()
> > length just to ensure the patched code is functionally the same as
> > before the patch.
> 
> Using fw->pda_size should be fine. The value comes from a const static, set to 0x100 for Symbol.
> 

Actually it allocated 512 byte before. Should it probably be set to 0x200?

View attachment "orinoco-reduce-stack-usage" of type "text/x-diff" (3583 bytes)

Download attachment "signature.asc " of type "application/pgp-signature" (198 bytes)