lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LFD.2.00.0810111303510.3402@nehalem.linux-foundation.org>
Date:	Sat, 11 Oct 2008 13:10:52 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
cc:	Andrew Morton <akpm@...ux-foundation.org>, netdev@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Philip Langdale <philipl@...rt.org>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [GIT]: Networking for 2.6.28



On Sat, 11 Oct 2008, David Miller wrote:
> 
> So the proper include (of net/ip.h) is there in ip_vs_xmit.c, but this
> failure can also happen if CONFIG_INET is not enabled.
> 
> Are you doing that kind of test build?

No, but somebody is.

> This patch should fix that case, let me know if it works:

How about you test it? It wasn't my bug-report, I just reported another 
report from somebody who _does_ run randconfig.

Here's another one:

	drivers/built-in.o: In function `bt_poll_rfkill':
	toshiba_acpi.c:(.text+0x37346): undefined reference to `input_event'

where the cause seems to be a totally broken Kconfig entry ACPI_TOSHIBA.

You can't just do

	select INPUT_POLLDEV

since that in turn needs all the _other_ input stuff. Yes, yes, things 
like various keyboard drivers do exactly that, but they are already inside 
"if INPUT_KEYBOARD/INPUT_MISC" or similar.

So at the very least, you'd now have to have it do a "depends on INPUT" or 
something like that.

Or perhaps just make that particular _feature_ depend on it, rather than 
make the whole driver depend on or select it. 

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ