linux-kernel - Re: Looks broken to me: x86, cyrix: debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081011205858.GA21965@elte.hu>
Date:	Sat, 11 Oct 2008 22:58:58 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Maciej W. Rozycki" <macro@...ux-mips.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	torvalds@...ux-foundation.org
Subject: Re: Looks broken to me: x86, cyrix: debug


* Maciej W. Rozycki <macro@...ux-mips.org> wrote:

> On Sat, 11 Oct 2008, Alan Cox wrote:
> 
> > > +#define getCx86_old(reg) ({ outb((reg), 0x22); inb(0x23); })
> > 
> > Doesn't expand to any kind of returned value.
> 
>  Well, actually it returns the value of the inb() expression -- cf the 
> semantics of compound statements.  The rest looks suspicious indeed.

indeed it's broken - will sort it out. It's all about breakage that has 
been in this code since v2.6.20, see c6744955d0. Will likely revert the 
whole thing.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/