linux-kernel - Re: [PATCH 16/23] Staging: add echo cancelation module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081011063310.GW31838@xorcom.com>
Date:	Sat, 11 Oct 2008 08:33:10 +0200
From:	Tzafrir Cohen <tzafrir.cohen@...com.com>
To:	Greg KH <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org, David Rowe <david@...etel.com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 16/23] Staging: add echo cancelation module

While there are a number of small issues in this code, I personally
would like to first and foremost get a usable interface so I could get a
working echo canceller module into dahdi:
http://svn.digium.com/svn/dahdi/linux/trunk/
http://svn.digium.com/svn/dahdi/linux/trunk/drivers/dahdi/

(Don't preach me that it should be included in mainline. Or if you do,
do it in a different thread, please)

1. echo.h (The interface) needlessly includes the definition of 
definition of echo_can_state_t. Anywhere in the interface it is used as
a pointer, including a _create and _destory function.

2. Furthermore, anybody that includes fir.h must also define malloc 
   first. See echo.c . fir.h is included for the definition of
   echo_can_state_t .

3. In that specific environment (dahdi/zaptel) echo_can is not a very
unique prefix. Thus in my provisional change I added oslec_ as a prefix.

I'm not sure how much (3) counts here.

My current working tree is in not in the best place: the debian
(non-existing) package dahdi-linux . See 

  http://svn.debian.org/viewsvn/pkg-voip?rev=6284&view=rev

I hope that once I get a clear enough interface I can kick out the oslec
subdirectory and move the EC module upstream.

Also:

On Fri, Oct 10, 2008 at 03:42:40PM -0700, Greg KH wrote:

> diff --git a/drivers/staging/echo/TODO b/drivers/staging/echo/TODO
> new file mode 100644
> index 0000000..1ca09af
> --- /dev/null
> +++ b/drivers/staging/echo/TODO
> @@ -0,0 +1,10 @@
> +TODO:

> +	- remove proc interface, only use echo.h interface (proc interface is
> +	  racy and not correct.)

Already done, right? I don't see any _wrapper.c around.

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen@...com.com
+972-50-7952406           mailto:tzafrir.cohen@...com.com
http://www.xorcom.com  iax:guest@...al.xorcom.com/tzafrir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/