| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20081012140936.M27503@cooldavid.org> Date: Sun, 12 Oct 2008 22:12:26 +0800 From: "Guo-Fu Tseng" <cooldavid@...ldavid.org> To: Jeff Layton <jlayton@...hat.com>, "Steve French" <smfrench@...il.com> Cc: rjw@...k.pl, "David Miller" <davem@...emloft.net>, netdev@...r.kernel.org, "samba-technical@...ts.samba.org" <samba-technical@...ts.samba.org>, "linux-cifs-client@...ts.samba.org" <linux-cifs-client@...ts.samba.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset On Sun, 12 Oct 2008 09:59:03 -0400, Jeff Layton wrote > On Sun, 12 Oct 2008 08:40:39 -0500 > "Steve French" <smfrench@...il.com> wrote: > > > Rafael and Guo-Fu, > > The following change to address the compile error that you noted is > > slightly different than what you suggested but should fix what you > > found. > > > > Actually, I like Adrian/Rafael's fix better. I think we should avoid > cluttering up the code with #ifdef's where possible. key_put() already > is a no-op when CONFIG_KEYS is disabled. We might as well do the same > thing with key_revoke(). I found that my patch was not reasonable at all. And I agree with Jeff. Guo-Fu Tseng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists