linux-kernel - Re: [RFC][PATCH] tty: remove the BKL in n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874p3gsrvt.fsf@basil.nowhere.org>
Date:	Mon, 13 Oct 2008 12:37:10 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linux-Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RFC][PATCH] tty: remove the BKL in n_tty.c

Frederic Weisbecker <fweisbec@...il.com> writes:
>  
> +
> +/*
> + * This Mutex is used to replace a big kernel lock that protected
> + * the access to tty->column.
> + */
> +static DEFINE_MUTEX(tty_column_mutex);

I suppose Alan did it already, but the general rule when doing
such changes is to lock data not code.

-Andi

-- 
ak@...ux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/