linux-kernel - Re: Distributed storage release.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081013141449.GA30768@2ka.mipt.ru>
Date:	Mon, 13 Oct 2008 18:14:49 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: Distributed storage release.

Hi Pekka.

On Mon, Oct 13, 2008 at 04:44:28PM +0300, Pekka Enberg (penberg@...helsinki.fi) wrote:
> > What's the difference? In saving one space and replacing another with
> > comma? I do not particulary care, but would like to know why it is
> > needed :)
> 
> kcalloc() will check for multiplication overflow which is nice
> especially if size is passed from user-space (not sure if that applies
> here).

I think that 32-bit overflow check during multiplication in allocation
code is the last thing to worry about :)
If this parameters are not checked before, we are screwd already...

P.S. DST does not check one of them, oops.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/