linux-kernel - Re: [PATCH] powerpc: fix fsl_upm nand driver modular build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <141BB874-FDA4-4107-BEF6-15B84023E44B@kernel.crashing.org>
Date:	Mon, 13 Oct 2008 11:48:38 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	avorontsov@...mvista.com
Cc:	Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH] powerpc: fix fsl_upm nand driver modular build


On Oct 8, 2008, at 7:32 PM, Anton Vorontsov wrote:

> The fsl_upm nand driver fails to build because fsl_lbc_lock isn't
> exported, the lock is needed by the inlined fsl_upm_run_pattern()
> function:
>
> ERROR: "fsl_lbc_lock" [drivers/mtd/nand/fsl_upm.ko] undefined!
>
> Dave Jones purposed to export the lock, but it is better to just  
> uninline
> the fsl_upm_run_pattern().
>
> When uninlined we also no longer need the exported fsl_lbc_regs, and
> both fsl_lbc_lock and fsl_lbc_regs could be marked static.
>
> While at it, also add some missing includes that we should have  
> included
> explicitly.
>
> Reported-by: Dave Jones <davej@...hat.com>
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
> ---


applied.

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/