linux-kernel - Re: [PATCH] pata_of_platform: fix no irq handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48F2F138.6020103@kernel.org>
Date:	Mon, 13 Oct 2008 15:56:56 +0900
From:	Tejun Heo <tj@...nel.org>
To:	avorontsov@...mvista.com
CC:	Jeff Garzik <jgarzik@...ox.com>, Li Yang <leoli@...escale.com>,
	Wang Jian <lark@...ux.net.cn>,
	"Steven A. Falco" <sfalco@...ris.com>, linuxppc-dev@...abs.org,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pata_of_platform: fix no irq handling

Anton Vorontsov wrote:
> When no irq specified the pata_of_platform fills the irq_res with -1,
> which is wrong to do for two reasons:
> 
> 1. By definition, 'no irq' should be IRQ 0, not some negative integer;
> 2. pata_platform checks for irq_res.start > 0, but since irq_res.start
>    is unsigned type, the check will be true for `-1'.
> 
> Reported-by: Steven A. Falco <sfalco@...ris.com>
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>

applied to #tj-upstream (will soon be sent upstream)

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/