linux-kernel - Re: Linux 2.6.27-git3: rtl8169 oops and wireless missing symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081013.161228.74135367.davem@davemloft.net>
Date:	Mon, 13 Oct 2008 16:12:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jamagallon@....com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Linux 2.6.27-git3: rtl8169 oops and wireless missing symbols

From: "J.A. Magallón" <jamagallon@....com>
Date: Tue, 14 Oct 2008 01:02:02 +0200

> Booting .27-git3 on the Aspire One gave me a couple oopses.

Fixed by:

commit 738e1e694bf6d9e965ba0ce2667a1bec5780a172
Author: Petr Vandrovec <petr@...drovec.name>
Date:   Sun Oct 12 20:58:29 2008 -0700

    r8169: NULL pointer dereference on r8169 load
    
    mmio_addr in r8169 needs to be initialized before use
    
    Maybe that all tp-> initialization should be moved before rtl_init_mac_address call,
    but this is enough to get rid of crash in rtl_rar_set due to mmio_addr being uninitialized.
    
    Signed-off-by: Petr Vandrovec <petr@...drovec.name>
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index bdae2c5..c821da2 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -2154,6 +2154,8 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	spin_lock_init(&tp->lock);
 
+	tp->mmio_addr = ioaddr;
+
 	rtl_init_mac_address(tp, ioaddr);
 
 	/* Get MAC address */
@@ -2186,7 +2188,6 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 #endif
 
 	tp->intr_mask = 0xffff;
-	tp->mmio_addr = ioaddr;
 	tp->align = cfg->align;
 	tp->hw_start = cfg->hw_start;
 	tp->intr_event = cfg->intr_event;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/