linux-kernel - Re: acpi-test tree on eeepc: EC error message on second resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1223877396.4141.33.camel@yakui_zhao.sh.intel.com>
Date:	Mon, 13 Oct 2008 13:56:36 +0800
From:	Zhao Yakui <yakui.zhao@...el.com>
To:	Alexey Starikovskiy <astarikovskiy@...e.de>
Cc:	Alan Jenkins <alan-jenkins@...fmail.co.uk>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Alexey Starikovskiy <aystarik@...il.com>,
	linux acpi <linux-acpi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: acpi-test tree on eeepc: EC error message on second resume

On Sun, 2008-10-12 at 23:23 +0400, Alexey Starikovskiy wrote:
> +static int ec_wait_ibf0(struct acpi_ec *ec)
> +{
> +       unsigned long delay = jiffies +
> msecs_to_jiffies(ACPI_EC_DELAY);
> +       while (time_before(jiffies, delay)) {
> +               if (wait_event_timeout(ec->wait, ec_check_ibf0(ec),
> +                                       msecs_to_jiffies(1)))
> +               return 0;
Please add the bogus timeout check.
best regards.
   Yakui
> +       }
> +       return -ETIME;
> +}
> + 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/