linux-kernel - Re: [mmotm 10 Oct][PATCH 2/2] fix build error of vmscan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Oct 2008 01:25:43 +0100 (BST)
From:	Hugh Dickins <hugh@...itas.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>
Subject: Re: [mmotm 10 Oct][PATCH 2/2] fix build error of vmscan

On Sun, 12 Oct 2008, KOSAKI Motohiro wrote:
> 
> Patch against: mmotm 10 Oct
> Patch name: vmscan-fix-pagecache-reclaim-referenced-bit-check-fix-fix-fix.patch
> Applied after: vmscan-fix-pagecache-reclaim-referenced-bit-check-fix-fix.patch
> 
> 
> --------
> vmscan-fix-pagecache-reclaim-referenced-bit-check-fix.patch introduce following build error.
> 
>   CC      mm/vmscan.o
> mm/vmscan.c: In function 'shrink_active_list':
> mm/vmscan.c:1248: error: too few arguments to function 'page_referenced'
> make[1]: *** [mm/vmscan.o] Error 1
> make: *** [mm] Error 2
> 
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> CC: Rik van Riel <riel@...hat.com>
> CC: Andrew Morton <akpm@...ux-foundation.org>

Excellent though it is, I'd prefer Andrew to ignore your patch:
because it falls within an unbisectable extent of the mmotm series,
for which I've now prepared a metapatch including this fix,
following in a minute or two.

Thanks,
Hugh

> 
> ---
>  mm/vmscan.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: b/mm/vmscan.c
> ===================================================================
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1245,7 +1245,8 @@ static void shrink_active_list(unsigned 
>  		}
>  
>  		/* page_referenced clears PageReferenced */
> -		if (page_mapping_inuse(page) && page_referenced(page))
> +		if (page_mapping_inuse(page) &&
> +		    page_referenced(page, 0, sc->mem_cgroup))
>  			pgmoved++;
>  
>  		list_add(&page->lru, &l_inactive);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/