| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3aaafc130810141027p660efb62p92c586b1c40a5e71@mail.gmail.com> Date: Tue, 14 Oct 2008 13:27:42 -0400 From: "J.R. Mauro" <jrm8005@...il.com> To: linux-kernel@...r.kernel.org Subject: Lindent and __user, etc. Indent doesn't understand macros and typedefs, so when running Lindent it makes some wrong suggestions about pointers. For example, something like "void fun(void __iomem *ptr)" comes back as "void fun(void __iomem * ptr)" from Lindent. I emailed the maintainer, and as indent doesn't do any parsing, the only solution is by telling it your typedefs with -T. Obviously, telling Lindent about every typedef and special macro in the kernel might be prohibitive, but should it at least know about __kernel, __user, etc. and all the u8, u16, etc. typedefs? Letting indent know about some common typenames will also help it find other style bugs it currently misses. I can submit more examples if desired, and I'll submit a patch to Lindent if people think it would be a good idea. Please CC me directly with replies. Thanks, J.R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists