linux-kernel - Re: [REVERT Request] VT Breakage (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 14 Oct 2008 13:44:55 -0400 (EDT)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	"Alexander V. Lukyanov" <lav@...is.ru>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [REVERT Request] VT Breakage (fwd)

On Tuesday 2008-10-14 13:03, Linus Torvalds wrote:
>
>Alexander, is your patch the same as mine, or something else?

Something else, you reverted more.

>@@ -400,7 +400,7 @@ static u8 build_attr(struct vc_data *vc, u8 _color, u8 _intensity, u8 _blink,
>  *  Bit 7   : blink
>  */
> 	{
>-	u8 a = _color;
>+	u8 a = vc->vc_color;
> 	if (!vc->vc_can_do_color)
> 		return _intensity |
> 		       (_italic ? 2 : 0) |

This hunk for example was not reverted in Alexander's patch. I think it 
should remain at reading "a = _color", because the caller(s) can just be 
updated to use pass in vc->vc_color for _color. Actually, the callers 
already do just this.

>Jan, if different, can you test this?

>@@ -1890,9 +1883,9 @@ static int fbcon_scroll(struct vc_data *vc, int t, int b, int dir,
> 			scr_memsetw((unsigned short *) (vc->vc_origin +
> 							vc->vc_size_row *
> 							(b - count)),
>-				    vc->vc_scrl_erase_char,
>+				    vc->vc_video_erase_char,
> 				    vc->vc_size_row * count);
>-			ret = 1;
>+			return 1;
> 			break;
> 
> 		case SCROLL_WRAP_MOVE:

His patch remained at "ret = 1". It should not cause any difference 
besides potential compiler optimizations --- control would just trickle 
through all the break;s and then return shortly with 'ret' anyway):

>-	vc->vc_video_erase_char = saved_ec;
>-	return ret;
>+	return 0;
> }

As such, your patch is producing the same net effect
for me as Alexander's.

As for you being unable to reproduce it, it is imperial to test the 
linux vt-on-a-VGA. You cannot cheat using UML-in-a-xterm (that was a bit 
of a surprise even to me, so I let you know), serial console or anything 
like that.

The expected output is http://tinyurl.com/3zs3dk
(color erased only on scroll; linewraps causing no scroll don't 
colorflood); behavior matches xterm.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/