linux-kernel - Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081013.184020.193699133.davem@davemloft.net>
Date:	Mon, 13 Oct 2008 18:40:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cooldavid@...ldavid.org
Cc:	kamalesh@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	apw@...dowen.org, jgarzik@...hat.com, ron.mercer@...gic.com,
	scofeldm@...co.com
Subject: Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()

From: "Guo-Fu Tseng" <cooldavid@...ldavid.org>
Date: Tue, 14 Oct 2008 03:28:14 +0800

> But since <net/ip6_checksum.h> compensate the lack of
> `csum_ipv6_magic` function defined in <asm/checksum.h>
> of some architecture, should <net/ip6_checksum.h> be
> included in <net/checksum.h> as well?

No, the standard convention is that if you need to call this
ipv6 checksumming routine you include net/ip6_checksum.h
From: "Guo-Fu Tseng" <cooldavid@...ldavid.org>
Date: Tue, 14 Oct 2008 03:28:14 +0800

> BTW, if there is a patch against jme driver which I maintain,
> and I just simply agree with it, should I silently noticed that
> and let someone like Jeff or David to review/apply it,
> or should I reply an ack of it?

You can ACK it and I usually apply patches like this directly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/