linux-kernel - Re: [GIT] HID patches for 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0810142205170.26779@jikos.suse.cz>
Date:	Tue, 14 Oct 2008 22:12:12 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	linux-kernel@...r.kernel.org, Jiri Slaby <jirislaby@...il.com>,
	Harvey Harrison <harvey.harrison@...il.com>
Subject: Re: [GIT] HID patches for 2.6.28

On Tue, 14 Oct 2008, Linus Torvalds wrote:

> The new Kconfig options are almost uselessly described, and very 
> annoying and this adds several new warnings of the type:
> 	drivers/hid/hid-lg.c:342: warning: ?hid_compat_logitech? defined but not used
> which is just unacceptable.

Hmm, this is because of Harvey Harrison's (CC added) patch that was used 
to silence sparse warning, but it is wrong as Jiri correctly pointed out 
on http://lkml.org/lkml/2008/9/4/495 but I somehow completely missed that 
mail.

Will fix that up.

> As to the Kconfig options - do they really add so much space that you 
> need to ask for the quirks? You didn't use to. Can you make the 
> questions depend on EMBEDDED, or at least on the HID_COMPAT thing or 
> whatever?

Probably makes sense, yes. I will send you a new pull request.

-- 
Jiri Kosina
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/