linux-kernel - Re: [PATCH] serial: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1223968124.4282.4.camel@odie.local>
Date:	Tue, 14 Oct 2008 09:08:44 +0200
From:	Simon Holm Thøgersen <odie@...aau.dk>
To:	Jianjun Kong <kongjianjun@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Alan Cox <alan@...hat.com>, David Miller <davem@...emloft.net>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: remove unused variable

tir, 14 10 2008 kl. 13:50 +0800, skrev Jianjun Kong:
> On Tue, Oct 14, 2008 at 12:58:31AM +0200, Simon Holm Th�gersen wrote:
> >This fixes the following compile warning:
> >
> >drivers/serial/8250.c: In function 'serial8250_init':
> >drivers/serial/8250.c:2963: warning: unused variable 'i'
> >
> >that was introduced by b70ac771 (serial: allow 8250 to be used on sparc)
> >that removed the last use of the variable.
> >
> >Signed-off-by: Simon Holm Thøgersen <odie@...aau.dk>
> >---
> > drivers/serial/8250.c |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
> >index d4104a3..625fc20 100644
> >--- a/drivers/serial/8250.c
> >+++ b/drivers/serial/8250.c
> >@@ -2960,7 +2960,7 @@ EXPORT_SYMBOL(serial8250_unregister_port);
> > 
> > static int __init serial8250_init(void)
> > {
> >-	int ret, i;
> >+	int ret;
> > 
> > 	if (nr_uarts > UART_NR)
> > 		nr_uarts = UART_NR;
> 
> I find those code in this function  __init serial8250_init(void)
> 
>         for (i = 0; i < NR_IRQS; i++)
>                 spin_lock_init(&irq_lists[i].lock);
> 
> So you do not remove the 'i'.
> 
Look at the referenced commit b70ac771 (serial: allow 8250 to be used on
sparc). It is quite recent (Mon Oct 13 10:36:31 2008 +0100), but if you
pull Linus' latest tree it is there.


Simon

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/