linux-kernel - Re: [PATCH] mfd: Don't use NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Oct 2008 07:55:17 -0400
From:	Samuel Ortiz <sameo@...nedhand.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...nel.org>
Subject: Re: [PATCH] mfd: Don't use NO_IRQ in WM8350




On Wed, 15 Oct 2008 11:20:54 +0100, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> NO_IRQ is only defined on some architectures - the general way to test
> for an invalid IRQ in the modern kernel is by comparing with zero.
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Applied, thanks.
I'll send a pull request to Linus soon.

Cheers,
Samuel.


> ---
> 
> This is a build fix for platforms that don't define NO_IRQ (which is
> most of them).  Please merge as soon as possible.
> 
>  drivers/mfd/wm8350-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> index 25a7a5d..bf87f67 100644
> --- a/drivers/mfd/wm8350-core.c
> +++ b/drivers/mfd/wm8350-core.c
> @@ -1217,7 +1217,7 @@ int wm8350_device_init(struct wm8350 *wm8350, int
> irq,
>  
>  	mutex_init(&wm8350->irq_mutex);
>  	INIT_WORK(&wm8350->irq_work, wm8350_irq_worker);
> -	if (irq != NO_IRQ) {
> +	if (irq) {
>  		ret = request_irq(irq, wm8350_irq, 0,
>  				  "wm8350", wm8350);
>  		if (ret != 0) {
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/