lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 15 Oct 2008 09:44:46 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH tip/tracing/markers] markers: let marker_table be close
	to its comments

* Lai Jiangshan (laijs@...fujitsu.com) wrote:
> 
> marker_table is defined far from its comments, this fix make
> cleanup for it.
> 

Good idea! Thanks.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>


> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> ---
> diff --git a/kernel/marker.c b/kernel/marker.c
> index e9c6b2b..e49a9c5 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -43,6 +43,7 @@ static DEFINE_MUTEX(markers_mutex);
>   */
>  #define MARKER_HASH_BITS 6
>  #define MARKER_TABLE_SIZE (1 << MARKER_HASH_BITS)
> +static struct hlist_head marker_table[MARKER_TABLE_SIZE];
>  
>  /*
>   * Note about RCU :
> @@ -67,8 +68,6 @@ struct marker_entry {
>  	char name[0];	/* Contains name'\0'format'\0' */
>  };
>  
> -static struct hlist_head marker_table[MARKER_TABLE_SIZE];
> -
>  /**
>   * __mark_empty_function - Empty probe callback
>   * @probe_private: probe private data
> 
> 
> 
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ