linux-kernel - Re: [PATCH 1/2] hpt366: add hpt3xx_disable_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Oct 2008 01:19:04 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] hpt366: add hpt3xx_disable_fast_irq() helper

Hello.

Bartlomiej Zolnierkiewicz wrote:

>>> * Factor out disabling of "fast interrupt" prediction from
>>>   init_hwif_hpt366() to hpt3xx_disable_fast_irq() helper.
>>>       
>>> * Use hpt3xx_disable_fast_irq() in ->init_chipset instead of
>>>   ->init_hwif method.
>>>       
>>>   This is a preparation for adding proper PCI PM support.
>>>       
>>> While at it:
>>>       
>>> * Cache chip type in chip_type variable in hpt3xx_disable_fast_irq().
>>>       
>>> There should be no functional changes caused by this patch.
>>>       
>>     Except a warning. ;-)
>>     
>
> Sorry for that but... shit happens. ;)
>   

   Compile testing the patches would have helped. ;-)

>>     You've removed the users of that variable but left the variable itself... 
>> alas, it's too late to fix the patch. :-/
>>     
>
> Not such a big deal, we just have to make an another one...
>
> From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> Subject: [PATCH] hpt366: fix compile warning
>
> Fixup for commit 1785192b5310ee25165768f5bb80f13146788e3e
> ("hpt366: add hpt3xx_disable_fast_irq() helper"):
>
>    CC      drivers/ide/pci/hpt366.o
> drivers/ide/pci/hpt366.c: In function `init_hwif_hpt366':
> drivers/ide/pci/hpt366.c:1290: warning: unused variable `dev'
>
> Reported-by: Sergei Shtylyov <sshtylyov@...mvista.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
>   

   Duh. I've posted this patch a bit earlier. ;-)

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/