linux-kernel - Re: [METAPATCH] mmotm: fix split-lru bisectability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 15 Oct 2008 14:39:15 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Hugh Dickins <hugh@...itas.com>
Cc:	riel@...hat.com, Lee.Schermerhorn@...com,
	kosaki.motohiro@...fujitsu.com, nickpiggin@...oo.com.au,
	linux-kernel@...r.kernel.org
Subject: Re: [METAPATCH] mmotm: fix split-lru bisectability

On Tue, 14 Oct 2008 01:32:18 +0100 (BST)
Hugh Dickins <hugh@...itas.com> wrote:

> There's an unbisectable 24-patch extent in the mmotm series, from
> define-page_file_cache-function to mlock-mlocked-pages-are-unevictable-fix:
> unbisectable because startup gets swamped by "Bad page state" messages
> (with three unrelated build errors and their fixes along the way).
> 
> These bad page states come from when Linus fasttracked the PAGE_FLAGS
> "cleanup" into 2.6.26, conflicting with PG_swapbacked patches already
> queued in -mm, and then the merge was botched.  We fixed up the end
> result at the time, but never got around to fixing the intermediates.
> It would be regrettable if this unbisectability were preserved in git.
> 
> To apply this metapatch, cd into mmotm's broken-out or patches directory
> (before define-page_file_cache-function has been applied), move series
> file there if it's kept elsewhere, apply metapatch with "patch -p1" (one
> file is deleted from series), then move back series file if necessary.
> 
> Based on mmotm .DATE=2008-10-10-19-22.  Doesn't bother to update the
> diffstats: I've tried to keep the diffs minimal, without all the noise
> which a quilt refresh here would have added.  So oddly I'm commenting
> out NORECL_PGRESCUED and NORECL_PGCULLED in one patch, then removing
> those lines in their fix patch - hmm, shouldn't they have got defined
> eventually, and that code restored?  End result is the same as mmotm,
> except that KOSAKI-San's page_referenced() args fix is included.
> 
> I'm pleased to say that checkpatch.pl reports that this metapatch
> has no obvious style problems and is ready for submission :-)
> 
> Signed-off-by: Hugh Dickins <hugh@...itas.com>
> ---
> 
>  series                                                       |    1 
>  define-page_file_cache-function.patch                        |   26 +++++--
>  vmscan-fix-pagecache-reclaim-referenced-bit-check-fix.patch  |    5 -
>  unevictable-lru-infrastructure.patch                         |   12 +--
>  unevictable-lru-infrastructure-defer-vm-event-counting.patch |    4 -
>  mlock-mlocked-pages-are-unevictable.patch                    |   24 -------
>  mlock-mlocked-pages-are-unevictable-fix.patch                |   33 ----------
>  7 files changed, 32 insertions(+), 73 deletions(-)

OK, thanks, I did that.  Fingers crossed..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/