linux-kernel - Re: [PATCH] rtc: rtc-ds1286 and rtc-m48t35 need <linux/io.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081016121802.GA7248@alpha.franken.de>
Date:	Thu, 16 Oct 2008 14:18:02 +0200
From:	tsbogend@...ha.franken.de (Thomas Bogendoerfer)
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: rtc-ds1286 and rtc-m48t35 need <linux/io.h>

On Thu, Oct 16, 2008 at 09:28:47AM +0200, Geert Uytterhoeven wrote:
> With m68k allmodconfig, I get:
> 
> | drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
> | drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'
> | drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
> | drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'
> | drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
> | drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'
> | drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast
> | drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'
> 
> and
> 
> | drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
> | drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'
> | drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'
> | drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
> | drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'
> | drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast
> | drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'
> 
> Include <linux/io.h> to get access to the I/O API.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Acked-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>

Thanks for fixing and sorry for that. I'll do more build tests in
the future to avoid that.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/