linux-kernel - Re: [PATCH 72/80] tty: fix up gigaset a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48F762CA.4080608@imap.cc>
Date:	Thu, 16 Oct 2008 17:50:34 +0200
From:	Tilman Schmidt <tilman@...p.cc>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Hansjoerg Lipp <hjlipp@....de>
Subject: Re: [PATCH 72/80] tty: fix up gigaset a bit

Am 13.10.2008 11:44 schrieb Alan Cox:
> From: Alan Cox <alan@...hat.com>
> 
> Stephen's fixes reminded me that gigaset is still rather broken so fix it up
> a bit
> 
> Signed-off-by: Alan Cox <alan@...hat.com>

Acked-by: Tilman Schmidt <tilman@...p.cc>

Thanks, Alan, for these improvements.
I'm now looking into the FIXME comments you added.

> @@ -571,6 +571,7 @@ gigaset_tty_close(struct tty_struct *tty)
>  	}
>  
>  	/* prevent other callers from entering ldisc methods */
> +	/* FIXME: should use the tty state flags */
>  	tty->disc_data = NULL;
>  
>  	if (!cs->hw.ser)

Do you know of an example line discipline that has got this right?
My model for this code was drivers/net/ppp_async.c but now it seems
that this was not as exemplary as I had hoped.

> @@ -680,6 +675,8 @@ gigaset_tty_ioctl(struct tty_struct *tty, struct file *file,
>  /*
>   * Poll on the tty.
>   * Unused, always return zero.
> + *
> + * FIXME: should probably return an exception - especially on hangup
>   */
>  static unsigned int
>  gigaset_tty_poll(struct tty_struct *tty, struct file *file, poll_table *wait)

Looking around, I see that many LDs don't even provide a poll method.
So I'm thinking of just dropping this one. Would that be ok?

Thanks,
Tilman

-- 
Tilman Schmidt                    E-Mail: tilman@...p.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


Download attachment "signature.asc" of type "application/pgp-signature" (251 bytes)