linux-kernel - Re: [PATCH] Add support for Dallas DS28CM00 Unique ID chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081016122502.3ad6e958.akpm@linux-foundation.org>
Date:	Thu, 16 Oct 2008 12:25:02 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mark Jackson <mpfj@...c.co.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add support for Dallas DS28CM00 Unique ID chip

On Tue, 07 Oct 2008 14:09:59 +0100
Mark Jackson <mpfj@...c.co.uk> wrote:

> This patch adds support for the (I2C based) DS28CM00 ID chip.

Please run scritps/checkpatch.pl across the diff and consider the
various things which it reports.  Many of them are minor layout issues.
The lack of printk facility levels is a should-fix thing.


>        printk("adding ds28cm00 driver !!\n");

Remove the " !!" :)

Please also cc i2c@...sensors.org on version 2.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/