linux-kernel - Re: [PATCH 1/7] powerpc and sparc: introduce dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40810161602v16232d96g2eb9af5c063f24f0@mail.gmail.com>
Date:	Thu, 16 Oct 2008 17:02:54 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"David Miller" <davem@...emloft.net>
Cc:	avorontsov@...mvista.com, linux-kernel@...r.kernel.org,
	dbrownell@...rs.sourceforge.net, sfalco@...ris.com,
	khali@...ux-fr.org, i2c@...sensors.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH 1/7] powerpc and sparc: introduce dev_archdata node accessors

On Thu, Oct 16, 2008 at 4:36 PM, David Miller <davem@...emloft.net> wrote:
> From: Anton Vorontsov <avorontsov@...mvista.com>
> Date: Thu, 16 Oct 2008 21:12:51 +0400
>
>> The name of the device_node field differ across the platforms, so we
>> have to implement inlined accessors. This is needed to avoid ugly
>> #ifdef in the generic code.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
>
> I'm happy to just change this member name on sparc to match
> powerpc's choice.
>
> That being said, this abstraction still has value and I'd
> like to let you merge this now and make forward progress
> so:
>
> Acked-by: David S. Miller <davem@...emloft.net>

I agree;

Acked-by: Grant Likely <grant.likely@...retlab.ca>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/