linux-kernel - Re: [PATCH 1/1] edac cell: fix incorrect edac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081016163532.273ea02f.akpm@linux-foundation.org>
Date:	Thu, 16 Oct 2008 16:35:32 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	dougthompson@...ssion.com
Cc:	benh@...nel.crashing.org, dougthompson@...ssion.com,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH 1/1] edac cell: fix incorrect edac_mode

On Thu, 16 Oct 2008 12:13:08 -0600
dougthompson@...ssion.com wrote:

> From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> 
> The cell_edac driver is setting the edac_mode field of the
> csrow's to an incorrect value, causing the sysfs show routine
> for that field to go out of an array bound and Oopsing the kernel
> when used.

Well that sounds a bit wrong of it.

> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Signed-off-by: Doug Thompson <dougthompson@...ssion.com>
> ---
> 
>  drivers/edac/cell_edac.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-work.orig/drivers/edac/cell_edac.c	2008-10-15 15:35:21.000000000 +1100
> +++ linux-work/drivers/edac/cell_edac.c	2008-10-15 15:35:29.000000000 +1100
> @@ -142,7 +142,7 @@ static void __devinit cell_edac_init_csr
>  		csrow->nr_pages = (r.end - r.start + 1) >> PAGE_SHIFT;
>  		csrow->last_page = csrow->first_page + csrow->nr_pages - 1;
>  		csrow->mtype = MEM_XDR;
> -		csrow->edac_mode = EDAC_FLAG_EC | EDAC_FLAG_SECDED;
> +		csrow->edac_mode = EDAC_SECDED;
>  		dev_dbg(mci->dev,
>  			"Initialized on node %d, chanmask=0x%x,"
>  			" first_page=0x%lx, nr_pages=0x%x\n",

Seems to be needed in 2.6.27.x?  Applies OK to 2.6.26, 2.6.25, etc.

How far back shold we port this?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/