linux-kernel - [PATCH] [ConfigFS]: Allow symbolic links from a SysFS struct kobject source.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1224226555.5556.279.camel@haakon2.linux-iscsi.org>
Date:	Thu, 16 Oct 2008 23:55:55 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Joel Becker <joel.becker@...cle.com>, Greg KH <greg@...ah.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	"Linux-iSCSI.org Target Dev" 
	<linux-iscsi-target-dev@...glegroups.com>,
	SCST-Devel <scst-devel@...ts.sourceforge.net>,
	Alan Stern <stern@...land.harvard.edu>,
	Andrew Morton <akpm@...l.org>,
	Christoph Hellwig <hch@...radead.org>
Subject: [PATCH] [ConfigFS]: Allow symbolic links from a SysFS struct
	kobject source.

Hi Joel, Greg and Co,

Here is the the first working code for allowing configfs to handle
symlinks from sysfs struct kobject based code.  Here is the commit:
passing struct kobject into generic target_core_mod subsystem plugins
for locating struct block_device and struct scsi_device..  

-------------------------------------------------------------------------

In struct configfs_item_operations, added allow_link_kobject() and
drop_link_kobject() to allow struct kobject to be passed through
the configfs API.  The code for kobject symlink source sits along side
the exist configfs symlink code, and does not break existing apps that use
allow_link() or drop_link().

Also, there is two large FIXMEs with the first commit,  in
fs/configfs/symlink.c:configfs_symlink() related to comparing
struct nameidata nd.path.dentry->d_sb == sysfs_sb.

The 2nd is when doing a 'ls -la' inside of the config group directory
containg the symlink source from sysfs, the source link does not currently
appear..  I will be following up these two items..

Signed-off-by: Nicholas A. Bellinger
---
 fs/configfs/configfs_internal.h |    3 +-
 fs/configfs/symlink.c           |  168 +++++++++++++++++++++++++++------------
 include/linux/configfs.h        |    6 +-
 3 files changed, 123 insertions(+), 54 deletions(-)

the following commit can be found at:

http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=commit;h=317aefe74354c0140dc8aebff1ef9467b6f0c9ba

Comments..?  I will send along my patch to
drivers/lio-core/target_core_configfs.c in a moment to demonstrate how
to pull it all together with struct config_item_operations
allow_link_kobject() and drop_link_kobject()..

Download attachment "0001-ConfigFS-Allow-symbolic-links-from-a-SysFS-struct.patch" of type "application/mbox" (9617 bytes)