linux-kernel - Re: [Patch] uml: fix one compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1KqoV0-0002VW-90@pomaz-ex.szeredi.hu>
Date:	Fri, 17 Oct 2008 14:32:10 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	xiyou.wangcong@...il.com
CC:	akpm@...ux-foundation.org, xiyou.wangcong@...il.com,
	linux-kernel@...r.kernel.org, jdike@...toit.com, stable@...nel.org
Subject: Re: [Patch] uml: fix one compile error

On Fri, 17 Oct 2008, =?utf-8?Q?Am=C3=A9rico?= Wang wrote:
> On Thu, Oct 16, 2008 at 04:15:57PM -0700, Andrew Morton wrote:
> >On Thu, 16 Oct 2008 16:26:26 +0100
> >Am__rico Wang <xiyou.wangcong@...il.com> wrote:
> >
> >> 
> >> This patch fixed the following compile error:
> >> 
> >>   CC      arch/um/sys-i386/signal.o
> >>   /home/wangcong/Projects/linux-2.6/arch/um/sys-i386/signal.c: In
> >> function 'copy_sc_from_user':
> >> /home/wangcong/Projects/linux-2.6/arch/um/sys-i386/signal.c:182:
> >> warning: dereferencing 'void *' pointer
> >> /home/wangcong/Projects/linux-2.6/arch/um/sys-i386/signal.c:182:
> >> error: request for member '_fxsr_env' in something not a structure or
> >> union
> >> 
> >> 
> >> Signed-off-by: WANG Cong <wangcong@...ux.org>
> >> Cc: jdike@...toit.com
> >> 
> >> ---
> >> diff --git a/arch/um/sys-i386/signal.c b/arch/um/sys-i386/signal.c
> >> index fd0c25a..1296473 100644
> >> --- a/arch/um/sys-i386/signal.c
> >> +++ b/arch/um/sys-i386/signal.c
> >> @@ -179,7 +179,8 @@ static int copy_sc_from_user(struct pt_regs *regs,
> >>  	if (have_fpx_regs) {
> >>  		struct user_fxsr_struct fpx;
> >>  
> >> -		err = copy_from_user(&fpx, &sc.fpstate->_fxsr_env[0],
> >> +		err = copy_from_user(&fpx,
> >> +			&((struct _fpstate __user *)sc.fpstate)->_fxsr_env[0],
> >>  				     sizeof(struct user_fxsr_struct));
> >>  		if (err)
> >>  			return 1;
> >
> >Which kernel versions are affected by this error? 2.6.27?
> 
> I haven't tried a stable version, but I will. :)

2.6.27 as UML works for me without the patch.

But it is needed for 2.6.28...  thanks.

Tested-by: Miklos Szeredi <mszeredi@...e.cz>

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/