linux-kernel - Re: [patch] gpiolib: fix oops in gpio_get_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081016175449.4ba7ac02.akpm@linux-foundation.org>
Date:	Thu, 16 Oct 2008 17:54:49 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Brownell <david-b@...bell.net>
Cc:	avorontsov@...mvista.com, linux-kernel@...r.kernel.org,
	stable@...nel.org
Subject: Re: [patch] gpiolib: fix oops in gpio_get_value_cansleep()

On Thu, 16 Oct 2008 17:44:33 -0700 David Brownell <david-b@...bell.net> wrote:

> On Thursday 16 October 2008, Andrew Morton wrote:
> > > From: David Brownell <dbrownell@...rs.sourceforge.net>
> > > 
> > > We can get the following oops from gpio_get_value_cansleep()
> > > when a GPIO controller doesn't provide a get() callback:
> > 
> > We can, but do we? ;)
> 
> I think it's unlikely without the sysfs interface.
> 
> 
> > iow: is this needed in any -stable release?
> 
> The bug has been there since 2.6.25 but nobody else seems
> to have reported it.  Is the general policy to fix all
> oopses that *could* appear?  I'd send it for 2.6.27-stable,
> since that's got the sysfs hooks.  And older kernels if
> bug likelihood isn't a major concern.

OK.  2.6.27 definitely (major distros are basing on that).

As for earlier kernels: I'd say so.  An oops is farily serious. 
Although an oops in a sysfs handler tends to be fairly tame, as the
code usually doesn't hold locks or many allocated resources.

Anyway - making decisions like this is why we pay stable@...nel.org the
big bucks :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/