linux-kernel - Re: [PATCH] Enable console on PCI serial devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200810170846.41032.bjorn.helgaas@hp.com>
Date:	Fri, 17 Oct 2008 08:46:40 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	n0ano@...no.com
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, donald.d.dugger@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Enable console on PCI serial devices

On Friday 17 October 2008 08:11:02 am n0ano@...no.com wrote:
> On Fri, Oct 17, 2008 at 10:28:58AM +0100, Alan Cox wrote:
> > Different discussion and different patches. We can get patches in for the
> > crystal frequency stuff and then debate the rest later
> 
> In that case, here is the crystal frequency patch (typos fixed and
> proper sign off line).

I like this patch, except ...

> +			"options" are the same as for ttyS, above.  "clk"
> +			is the crystal frequency which defaults to 115200
> +			(typically the fastest baud rate supported by the
> +			uart) but some hardware use different crystals.

this text is a little confusing.  Since you multiply by 16 below, the
number specified by the user isn't really the crystal frequency, is it?

> +	options = strchr(options, ',');
> +	if (options) {
> +		options++;
> +		port->uartclk = simple_strtoul(options, NULL, 0) * 16;
> +	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/