lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Oct 2008 13:25:01 -0700 From: David Brownell <david-b@...bell.net> To: Anton Vorontsov <avorontsov@...mvista.com> Cc: linux-kernel@...r.kernel.org, David Brownell <dbrownell@...rs.sourceforge.net>, "Steven A. Falco" <sfalco@...ris.com>, Grant Likely <grant.likely@...retlab.ca>, Jean Delvare <khali@...ux-fr.org>, David Miller <davem@...emloft.net>, i2c@...sensors.org, linuxppc-dev@...abs.org Subject: Re: [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add,remove} calls On Thursday 16 October 2008, Anton Vorontsov wrote: > + if (of_gc->chip) > + return of_gc->chip; > + return &of_gc->gc; presumably there's a reason not to of_gc->chip = &of_gc->gc; when this gets set up, so this can always be a simple return of_gc->chip; (and inlined)? Needlessly complex... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists