linux-kernel - Re: [PATCH] Fix broken debug output reserve_region_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1224214314.7654.65.camel@pasglop>
Date:	Fri, 17 Oct 2008 14:31:54 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Geert.Uytterhoeven@...ycom.com, hpa@...or.com,
	linux-kernel@...r.kernel.org, mingo@...e.hu, yhlu.kernel@...il.com,
	David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Fix broken debug output reserve_region_with_split()

On Thu, 2008-10-16 at 20:13 -0700, Roland Dreier wrote:
> > + * Right now we handle:
>  > + *
>  > + * - 'F' For symbolic Function descriptor pointers
>  > + * - 'S' For Symbolic direct pointers), but this can easily be
>  > + *       extended in the future (network address types etc).
>  > + * - 'R' For a struct resouce pointer, it prints the range of
>  > + *       addresses (not the name nor the flags)
> 
> A little too much cut and paste -- the "easily be extended" bit at 'S'
> doesn't really make sense in the middle of the list.

Right :-)

>  > + * Note: The difference between 'S' and 'F' is that on ia64 and ppc64
>  > + * function pointers are really function descriptors, which contain a
>  > + * pointer the real address.
> 
> you cut and pasted Linus's typo too -- "a pointer the real address"
> should probably be "a pointer *TO* the real address"

Ok, I'll wait for more comments before a respin to :-) I'm mostly
wondering whether to use fixed sized format rather than the current
variable size (and pad with zeros).

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/