linux-kernel - Re: [GIT PATCH] USB patches for 2.6-git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Oct 2008 15:47:58 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Greg KH <gregkh@...e.de>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [GIT PATCH] USB patches for 2.6-git

On Fri, 17 Oct 2008, Greg KH wrote:
>
> Here is the big batch of USB patches for your 2.6-git tree.

I really wish I were to get the occasional _clean_ pull for a change.

f*ck me, but why do people keep adding more and more warnings, and 
apparently not even bother to write clean code? The merge window is no 
excuse for badly written crap.

  drivers/usb/host/ehci-hcd.c: In function ‘ehci_hcd_init’:
  drivers/usb/host/ehci-hcd.c:1115: warning: label ‘err_debug’ defined but not used

That particular function is just about the ugliest thing I've ever seen, 
and now it's adding annoying warnings too!

Yeah, I'm grumpy. The quality control during this merge window has been 
absolutely disgusting. I feel like I have to complain about every other 
pull I do, because people feel like another new warning isn't a problem. 
And every single time, the new warning is due to some total crap code.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/