linux-kernel - Re: [PATCH] Fix broken debug output reserve_region_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0810162036510.3438@nehalem.linux-foundation.org>
Date:	Thu, 16 Oct 2008 20:49:00 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
cc:	Roland Dreier <rdreier@...co.com>, Geert.Uytterhoeven@...ycom.com,
	hpa@...or.com, linux-kernel@...r.kernel.org, mingo@...e.hu,
	yhlu.kernel@...il.com, David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Fix broken debug output reserve_region_with_split()

On Fri, 17 Oct 2008, Benjamin Herrenschmidt wrote:
> 
> Ok, I'll wait for more comments before a respin to :-) I'm mostly
> wondering whether to use fixed sized format rather than the current
> variable size (and pad with zeros).

Sadly, I think that gcc warns if we were to support %08pR, so we can't 
pass down flags.

That said, I don't much like SPECIAL in the flags. We never do that thing. 
Doing a git grep for some range printouts, we tend to do things like

	[%lx,%lx]
	[%x - %x]
	[%llx, %llx]
	[%016lx - %016lx]
	<%016llx-%016llx>

But using "0x%llx" or "%#llx" is very rare. It happens (notably 
drivers/pci/setup-res.c), but it's not common.

But it would be kind of nice to be able to do extended flags. Maybe we 
could do it with

	%p04R

and the 04 would be parsed as flags, the same way we do %04x. And then if 
you want the 0x, you can use %p#08R..

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/