linux-kernel - Re: [PATCH] Fix broken debug output reserve_region_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48F832DB.2050502@zytor.com>
Date:	Thu, 16 Oct 2008 23:38:19 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	benh@...nel.crashing.org
CC:	Yinghai Lu <yinghai@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Geert.Uytterhoeven@...ycom.com, linux-kernel@...r.kernel.org,
	mingo@...e.hu, David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Fix broken debug output reserve_region_with_split()

Benjamin Herrenschmidt wrote:
> 
> With that patch, it will use just as many digits as necessary to display
> a given number. The question I'm asking in the comments is whether we
> want to instead use fixed digits with zero padding, and in that case,
> do we want a hook or something for archs to decide how many digits
> for IO vs. memory.
> 

Yes, and yes.

We want to pad to keep people from mistaking, say, c000000 from 
c0000000.  At least on x86, it also acts as a visual cue for the type of 
resource space, as people are used to seeing I/O ports as 16-bit numbers 
with four hexdigits, and 8- or 16-hexdigit numbers for memory addresses.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/