linux-kernel - Re: [PATCH] add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081018005936.GC27254@localhost.localdomain>
Date:	Fri, 17 Oct 2008 20:59:36 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	linux-kernel@...r.kernel.org, kexec@...ts.infradead.org,
	hbabu@...ibm.com
Subject: Re: [PATCH] add additional symbols to /sys/kernel/vmcoreinfo data
	for ppc(64)

On Fri, Oct 17, 2008 at 05:08:54PM -0400, Vivek Goyal wrote:
> On Thu, Oct 09, 2008 at 11:20:27AM -0400, Neil Horman wrote:
> > Hey-
> > 	The makdumpdile dump filtering program, in some modes of operation needs
> > the node_data and/or contig_page_data symbols to function properly.  These
> > symbols are missing from the powerpc kernel.  This patch adds those symbols in
> > properly.  Tested successfully by myself and the reporter.
> > 
> > Regards
> > Neil
> > 
> > Signed-off-by: Neil Horman <nhorman@...driver.com>
> > 
> > 
> >  machine_kexec.c |   10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > 
> > diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
> > index aab7688..2f9b5aa 100644
> > --- a/arch/powerpc/kernel/machine_kexec.c
> > +++ b/arch/powerpc/kernel/machine_kexec.c
> > @@ -44,6 +44,16 @@ void machine_kexec_cleanup(struct kimage *image)
> >  		ppc_md.machine_kexec_cleanup(image);
> >  }
> >  
> > +void arch_crash_save_vmcoreinfo(void)
> > +{
> > +#ifdef CONFIG_NEED_MULTIPLE_NODES
> > +	VMCOREINFO_SYMBOL(node_data);
> > +	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
> > +#else
> > +	VMCOREINFO_SYMBOL(contig_page_data);
> > +#endif
> > +}
> > +
> 
> Hi Neil,
> 
> Looks like contig_page_data is already being saved in arch independent
> portion of kexec (crash_save_vmcoreinfo_init()). We probably don't need
> to save it here again?
> 
> #ifndef CONFIG_NEED_MULTIPLE_NODES
>         VMCOREINFO_SYMBOL(mem_map);
>         VMCOREINFO_SYMBOL(contig_page_data);
> #endif
> 
> Thanks
> Vivek
> 
Oops your right.  I fixed that in RHEL and must not have searched for it
upstream.  I'll repost a corrected patch monday.
Thanks!
Neil

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/