linux-kernel - Re: [PATCH] MMC: Fix race condition in resume/card detect code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081018191147.00327019@mjolnir.drzeus.cx>
Date:	Sat, 18 Oct 2008 19:11:47 +0200
From:	Pierre Ossman <drzeus-mmc@...eus.cx>
To:	Yauhen Kharuzhy <jekhor@...il.com>
Cc:	linux-kernel@...r.kernel.org, Yauhen Kharuzhy <jekhor@...il.com>
Subject: Re: [PATCH] MMC: Fix race condition in resume/card detect code

On Thu, 16 Oct 2008 19:09:36 +0300
Yauhen Kharuzhy <jekhor@...il.com> wrote:

> When device wakes up by card change interrupt and MMC_UNSAFE_RESUME is
> enabled then race condition between mmc_rescan() and
> mmc_resume()/mmc_sd_resume() appeared.
> 
> Resume functions can sleep into mmc_remove_card() and at this time
> mmc_rescan() can be called by delayed work handler. Double-free of
> kobject or double-remove of host->card can be result of this.
> 
> This patch adds an mutex which deny simultaneous executing of
> mmc_sd_resume()/mmc_resume() and mmc_rescan() functions. Probably, it is
> not right way.
> 
> Signed-off-by: Yauhen Kharuzhy <jekhor@...il.com>
> ---

Can't we just ask the PM layer if this device is currently resuming,
and if so ignore card notifications from the driver?

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/