linux-kernel - Re: appletouch regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f488382f0810181134h24ed5da8lc12e62816436bb5@mail.gmail.com>
Date:	Sat, 18 Oct 2008 11:34:32 -0700
From:	"Steven Noonan" <steven@...inklabs.net>
To:	"Justin Mattock" <justinmattock@...il.com>,
	"Jiri Slaby" <jslaby@...e.cz>, "Jiri Kosina" <jkosina@...e.cz>
Cc:	"Sven Anders" <anders@...uras.de>,
	"kernel list" <linux-kernel@...r.kernel.org>
Subject: Re: appletouch regression

On Sat, Oct 18, 2008 at 10:29 AM, Justin Mattock
<justinmattock@...il.com> wrote:
> On Sat, Oct 18, 2008 at 9:44 AM, Steven Noonan <steven@...inklabs.net> wrote:
>> 2008/10/18 Sven Anders <anders@...uras.de>:
>>> Steven Noonan schrieb:
>>>> It seems that the appletouch driver is (sporadically) not detecting my
>>>> Apple Trackpad anymore on Linus' current tree (2.6.27-05577-g0cfd810).
>>>> When it is misbehaving, it doesn't have any /dev/input/event* entry
>>>> that corresponds to the input from appletouch, and dmesg -should- show
>>>> the following, as 2.6.27.1 does, but does not:
>>>>
>>>> appletouch: Geyser mode initialized.
>>>> input: appletouch as /class/input/input4
>>>> usbcore: registered new interface driver appletouch
>>>> appletouch: 17" model detected
>>>>
>>>> On the current tree, occasionally all I get is:
>>>>
>>>> usbcore: registered new interface driver appletouch
>>>>
>>>> It's unfortunately a touchy issue, as it only -occasionally- happens.
>>>> A bisection will be a pain in the butt, but I'm starting it right now
>>>> anyway.
>>>
>>> Hmm, strange...
>>>
>>> I didn't change anything in the initialization routines. But I will take a look
>>> into the changes, if something is missing or wrong...
>>>
>>
>> I am pretty sure the two patches recently submitted by you are not
>> guilty (I tried reverting both of them, which had no effect).
>>
>> Still working on the git-bisect. Fell asleep in the middle of it last night. O.o
>>
>> - Steven
>
> I too have a lifeless apple touchpad,
> not sure when this started,due to never really using
> it unless I'm in a remote location.
>

I finished the git-bisect. Here's the log:
 # bad:  [0cfd8103] Merge git://git.kernel.org/pub/scm/linux/kernel/gi
 # good: [3fa8749e] Linux 2.6.27
 # good: [56c5d900] Merge branch 'master' of master.kernel.org:/pub/sc
 # good: [acd15a83] Merge branch 'upstream-linus' of git://git.kernel.
 # bad:  [c8d8a232] Merge git://git.kernel.org/pub/scm/linux/kernel/gi
 # bad:  [f055663c] checkpatch: report the correct lines for single st
 # good: [6dc64725] Merge commit 'origin'
 # bad:  [08da6f1b] MIPS: Kill unused <asm/debug.h> inclusions
 # bad:  [79575019] HID: convert to dev_* prints
 # bad:  [980a3da6] HID: move samsung quirks
 # bad:  [78a849a6] HID: move microsoft quirks
 # bad:  [022e8c4d] HID: move usage input mapping to hid.h
 # good: [85cdaf52] HID: make a bus from hid code
 # bad:  [990436a7] HID: move ids into separate file
 # bad:  [c500c971] HID: hid, make parsing event driven

So the bad commit seems to be:

commit c500c9714011edab021591340042787722db9cf0
Author: Jiri Slaby <jirislaby@...il.com>
Date:   Fri May 16 11:49:16 2008 +0200

    HID: hid, make parsing event driven

    Next step for complete hid bus, this patch includes:
    - call parser either from probe or from hid-core if there is no probe.
    - add ll_driver structure and centralize some stuff there (open, close...)
    - split and merge usb_hid_configure and hid_probe into several functions
      to allow hooks/fixes between them

    Signed-off-by: Jiri Slaby <jslaby@...e.cz>
    Signed-off-by: Jiri Kosina <jkosina@...e.cz>

Any ideas, gentlemen?

- Steven
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/