linux-kernel - Re: [PATCH v5] ELF: implement AT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a36005b50810172242u2ffd1049n68d956dbcd6e3fc2@mail.gmail.com>
Date:	Fri, 17 Oct 2008 22:42:01 -0700
From:	"Ulrich Drepper" <drepper@...il.com>
To:	"Kees Cook" <kees.cook@...onical.com>
Cc:	"Ulrich Drepper" <drepper@...hat.com>,
	"Jakub Jelinek" <jakub@...hat.com>,
	"Arjan van de Ven" <arjan@...radead.org>,
	"Roland McGrath" <roland@...hat.com>, linux-kernel@...r.kernel.org,
	libc-alpha@...rceware.org, "Ingo Molnar" <mingo@...e.hu>
Subject: Re: [PATCH v5] ELF: implement AT_RANDOM for glibc PRNG seeding

On Fri, Oct 3, 2008 at 10:59 AM, Kees Cook <kees.cook@...onical.com> wrote:
> While discussing[1] the need for glibc to have access to random bytes
> during program load, it seems that an earlier attempt to implement
> AT_RANDOM got stalled.  This implements a random 16 byte string, available
> to every ELF program via a new auxv AT_RANDOM vector.
>
> [1] http://sourceware.org/ml/libc-alpha/2008-10/msg00006.html
>
> Signed-off-by: Kees Cook <kees.cook@...onical.com>
> ---
>  fs/binfmt_elf.c        |   12 ++++++++++++
>  include/linux/auxvec.h |    6 +++---
>  2 files changed, 15 insertions(+), 3 deletions(-)

This version is OK with me as long as the get_random_bytes call is
producing 16 reasonably random bytes.  If the random data generation
is changed at some point I'd want to have very strong PRNG for
binaries which have AT_SECURE set.

Acked-by: Ulrich Drepper <drepper@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/