linux-kernel - Re: [PATCH] vt: incomplete initialization of vc_tab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081018115712.GA16600@infradead.org>
Date:	Sat, 18 Oct 2008 07:57:12 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Wolfgang Kroworsch <wolfgang@...worsch.de>
Cc:	linux-kernel@...r.kernel.org, Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] vt: incomplete initialization of vc_tab_stop

On Sat, Oct 18, 2008 at 01:49:31PM +0200, Wolfgang Kroworsch wrote:
>  	vc->vc_tab_stop[1]	=
>  	vc->vc_tab_stop[2]	=
>  	vc->vc_tab_stop[3]	=
> -	vc->vc_tab_stop[4]	= 0x01010101;
> +	vc->vc_tab_stop[4]	=
> +	vc->vc_tab_stop[5]	=
> +	vc->vc_tab_stop[6]	=
> +	vc->vc_tab_stop[7]	= 0x01010101;
>  
> +					vc->vc_tab_stop[4] =
> +					vc->vc_tab_stop[5] =
> +					vc->vc_tab_stop[6] =
> +					vc->vc_tab_stop[7] = 0;

Using memset might be a beter idea.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/