linux-kernel - [PATCH 2/2] HID: fix appletouch regression (was Re: several messages)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0810200017150.27479@jikos.suse.cz>
Date:	Mon, 20 Oct 2008 00:23:26 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jiri Slaby <jirislaby@...il.com>
cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Steven Noonan <steven@...inklabs.net>,
	Justin Mattock <justinmattock@...il.com>,
	Sven Anders <anders@...uras.de>,
	Marcel Holtmann <marcel@...tmann.org>,
	linux-bluetooth@...r.kernel.org
Subject: [PATCH 2/2] HID: fix appletouch regression (was Re: several
 messages)


[ restored previous subject, sorry for the "several messagess" mess, 
alpine didn't handle multi-message reply with different subjects nicely ]

On Mon, 20 Oct 2008, Jiri Slaby wrote:

> >> +enum hid_type {
> >> +	HID_TYPE_UNKNOWN = 0,
> >> +	HID_TYPE_MOUSE,
> >> +	HID_TYPE_KEYBOARD
> > Do we really need the HID_TYPE_KEYBOARD at all? It's not used anywhere 
> > in the code. I'd propose to add it when it is actually needed. I.e. 
> > have the enum contain something like HID_TYPE_MOUSE HID_TYPE_OTHER for 
> > now, and add whatever will become necessary in the future, what do you 
> > think?
> I would use unknown rather than other, since on bluetooth mouse is unknown
> not other, if you don't mind?
> Or did you mean tristate unknown, mouse and other?

Well, basically the points I am trying to make:

1) the code doesn't currently need HID_TYPE_KEYBOARD at all

and

2) by definition, HID are not just mice and keyboards, so adding just 
   these two doesn't look particularly correct, if just one of them is 
   needed

For bluetooth we even don't have the possibility to distinguish these, 
yes. So probably something like HID_TYPE_USBMOUSE/HID_TYPE_OTHER for now, 
and we could extend the enum whenever the need to recognize a different 
type comes up?

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/