| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1224424839-3892-1-git-send-email-dmonakhov@openvz.org> Date: Sun, 19 Oct 2008 18:00:39 +0400 From: Dmitri Monakhov <dmonakhov@...nvz.org> To: linux-kernel@...r.kernel.org Cc: linux-fsdevel@...r.kernel.org, Dmitri Monakhov <dmonakhov@...nvz.org> Subject: [PATCH] kill suid bit only for regular files We don't have to do it because it is useless for non regular files. In fact block device may trigger this path without dentry->d_inode->i_mutex. Signed-off-by: Dmitri Monakhov <dmonakhov@...nvz.org> --- mm/filemap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index a2907d5..3d5a2e7 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1767,7 +1767,7 @@ int should_remove_suid(struct dentry *dentry) if (unlikely((mode & S_ISGID) && (mode & S_IXGRP))) kill |= ATTR_KILL_SGID; - if (unlikely(kill && !capable(CAP_FSETID))) + if (unlikely(kill && !capable(CAP_FSETID) && S_ISREG(mode))) return kill; return 0; -- 1.5.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists